pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry 3+ messages / 3 participants [nested] [flat]
Commits from this thread: 2025-01-24 6fc4fc42da Doc: Fix a typo introduced in 4a0e7314f1.
* pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry @ 2025-01-22 05:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 1 reply; 3+ messages in thread From: Amit Kapila @ 2025-01-22 05:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: Update the interaction of tablesync with wal_retrieve_retry_interval. In passing, update the documentation that explains the process of initial data replication to explicitly state that it uses a table synchronization worker. Author: Vignesh C Reviewed-by: Peter Smith, Shlok Kyal, Amit Kapila Discussion: https://postgr.es/m/CALDaNm3RxGcD4cDAV5Q0_A4n06F3+AAMpxiyND9Zn0dB86hFmg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4a0e7314f11ee03adfe9df945598c068b4179314 Modified Files -------------- doc/src/sgml/config.sgml | 3 ++- doc/src/sgml/logical-replication.sgml | 35 +++++++++++++++++++++++------------ 2 files changed, 25 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry @ 2025-01-23 11:26 Erik Rijkers <er@xs4all.nl> parent: Amit Kapila <akapila@postgresql.org> 0 siblings, 1 reply; 3+ messages in thread From: Erik Rijkers @ 2025-01-23 11:26 UTC (permalink / raw) To: Amit Kapila <akapila@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@postgresql.org> On 1/22/25 06:34, Amit Kapila wrote: > Doc: Update the interaction of tablesync with wal_retrieve_retry_interval. > Branch > ------ > master > > Details > ------- > https://git.postgresql.org/pg/commitdiff/4a0e7314f11ee03adfe9df945598c068b4179314 Hi, In this sentence : "The initial data in existing subscribed tables are snapshotted and copied in a parallel instances of a special kind of apply process." "copied in a parallel instances" seems wrong. It should be either (1) singular "in a parallel instance" or (2) plural "in parallel instances" I'm not sure which is meant. I also wonder if 'instance' is actually the correct word here at all; see the Glossary definition of 'instance': "A group of backend and auxiliary processes that communicate using a common shared memory area. One postmaster process manages the instance; one instance manages exactly one database cluster with all its databases. Many instances can run on the same server as long as their TCP ports do not conflict." Thanks, Erik > Modified Files > -------------- > doc/src/sgml/config.sgml | 3 ++- > doc/src/sgml/logical-replication.sgml | 35 +++++++++++++++++++++++------------ > 2 files changed, 25 insertions(+), 13 deletions(-) > ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry @ 2025-01-23 12:11 Amit Kapila <amit.kapila16@gmail.com> parent: Erik Rijkers <er@xs4all.nl> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2025-01-23 12:11 UTC (permalink / raw) To: Erik Rijkers <er@xs4all.nl>; +Cc: Amit Kapila <akapila@postgresql.org>; PostgreSQL Hackers <pgsql-hackers@postgresql.org> On Thu, Jan 23, 2025 at 4:56 PM Erik Rijkers <er@xs4all.nl> wrote: > > On 1/22/25 06:34, Amit Kapila wrote: > > Doc: Update the interaction of tablesync with wal_retrieve_retry_interval. > > Branch > > ------ > > master > > > > Details > > ------- > > https://git.postgresql.org/pg/commitdiff/4a0e7314f11ee03adfe9df945598c068b4179314 > > Hi, > > In this sentence : > > "The initial data in existing subscribed tables are snapshotted and > copied in a parallel instances of a special kind of apply process." > > "copied in a parallel instances" seems wrong. It should be either > (1) singular "in a parallel instance" or > (2) plural "in parallel instances" > > I'm not sure which is meant. > I meant the latter. It is a typo. I will fix it. > I also wonder if 'instance' is actually > the correct word here at all; see the Glossary definition of 'instance': > It is not introduced by this patch but sounds correct to me because the apply worker launches multiple table sync workers and they do communicate via different states to finish the initial synchronization. -- With Regards, Amit Kapila. ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-01-23 12:11 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-01-22 05:34 pgsql: Doc: Update the interaction of tablesync with wal_retrieve_retry Amit Kapila <akapila@postgresql.org> 2025-01-23 11:26 ` Erik Rijkers <er@xs4all.nl> 2025-01-23 12:11 ` Amit Kapila <amit.kapila16@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox