pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: checkpointer: Request checkpoint via latch instead of signal
Date: Fri, 24 Jan 2025 22:42:08 +0000
Message-ID: <E1tbSNL-003L6n-Oy@gemulon.postgresql.org> (raw)

checkpointer: Request checkpoint via latch instead of signal

The motivation for this change is that a future commit will use SIGINT for
another purpose (postmaster requesting WAL access to be shut down) and that
there no other signals that we could readily use (see code comment for the
reason why SIGTERM shouldn't be used). But it's also a tad nicer / more
efficient to use SetLatch(), as it avoids sending signals when checkpointer
already is busy.

Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Discussion: https://postgr.es/m/kgng5nrvnlv335evmsuvpnh354rw7qyazl73kdysev2cr2v5zu@m3cfzxicm5kp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4d271e3ec25138be360b5a6ee40ec8bfa12459e0

Modified Files
--------------
src/backend/postmaster/checkpointer.c | 58 +++++++++++------------------------
1 file changed, 18 insertions(+), 40 deletions(-)



Message-ID: <E1tbSNL-003L6n-Oy@gemulon.postgresql.org>
Permalink:  ../E1tbSNL-003L6n-Oy@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tbSNL-003L6n-Oy@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: checkpointer: Request checkpoint via latch instead of signal
  In-Reply-To: <E1tbSNL-003L6n-Oy@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox