From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postmaster: Don't repeatedly transition to crashing state
Date: Fri, 24 Jan 2025 22:42:08 +0000
Message-ID: <E1tbSNL-003L6r-Q2@gemulon.postgresql.org> (raw)
postmaster: Don't repeatedly transition to crashing state
Previously HandleChildCrash() skipped logging and signalling child exits if
already in an immediate shutdown or in FatalError state, but still
transitioned server state in response to a crash. That's redundant.
In the other place we transition to FatalError, we do take care to not do so
when already in FatalError state.
To make it easier to combine different paths for entering FatalError state,
only do so once in HandleChildCrash().
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/kgng5nrvnlv335evmsuvpnh354rw7qyazl73kdysev2cr2v5zu@m3cfzxicm5kp
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f0b7ab7251390544c5e79d1d9c96da254181fc4f
Modified Files
--------------
src/backend/postmaster/postmaster.c | 22 ++++++++--------------
1 file changed, 8 insertions(+), 14 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: postmaster: Don't repeatedly transition to crashing state
In-Reply-To: <E1tbSNL-003L6r-Q2@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox