pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postmaster: Adjust which processes we expect to have exited
Date: Fri, 24 Jan 2025 22:42:08 +0000
Message-ID: <E1tbSNL-003L6x-RS@gemulon.postgresql.org> (raw)

postmaster: Adjust which processes we expect to have exited

Comments and code stated that we expect checkpointer to have been signalled in
case of immediate shutdown / fatal errors, but didn't treat archiver and
walsenders the same. That doesn't seem right.

I had started digging through the history to see where this oddity was
introduced, but it's not the fault of a single commit.

Instead treat archiver, checkpointer, and walsenders the same.

Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/kgng5nrvnlv335evmsuvpnh354rw7qyazl73kdysev2cr2v5zu@m3cfzxicm5kp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f15538cd27d4eeb7d665263a3d7b5700362d7eb0

Modified Files
--------------
src/backend/postmaster/postmaster.c | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)



Message-ID: <E1tbSNL-003L6x-RS@gemulon.postgresql.org>
Permalink:  ../E1tbSNL-003L6x-RS@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tbSNL-003L6x-RS@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: postmaster: Adjust which processes we expect to have exited
  In-Reply-To: <E1tbSNL-003L6x-RS@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox