From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Merge copies of converting an XID to a FullTransactionId.
Date: Sat, 25 Jan 2025 19:29:54 +0000
Message-ID: <E1tblqs-003VLk-0k@gemulon.postgresql.org> (raw)
Merge copies of converting an XID to a FullTransactionId.
Assume twophase.c is the performance-sensitive caller, and preserve its
choice of unlikely() branch hint. Add some retrospective rationale for
that choice. Back-patch to v17, for the next commit to use it.
Reviewed (in earlier versions) by Michael Paquier.
Discussion: https://postgr.es/m/17821-dd8c334263399284@postgresql.org
Discussion: https://postgr.es/m/20250116010051.f3.nmisch@google.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/81772a495ec98d36eabf5cc294e7031a9545c5c1
Modified Files
--------------
contrib/amcheck/verify_heapam.c | 4 +-
src/backend/access/transam/twophase.c | 26 +++--------
src/backend/access/transam/xlogreader.c | 18 +-------
src/backend/utils/adt/xid8funcs.c | 79 ++++++++++-----------------------
src/include/access/transam.h | 43 ++++++++++++++++++
5 files changed, 77 insertions(+), 93 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Merge copies of converting an XID to a FullTransactionId.
In-Reply-To: <E1tblqs-003VLk-0k@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox