From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: At update of non-LP_NORMAL TID, fail instead of corrupting page
Date: Sat, 25 Jan 2025 19:29:54 +0000
Message-ID: <E1tblqs-003VLn-18@gemulon.postgresql.org> (raw)
At update of non-LP_NORMAL TID, fail instead of corrupting page header.
The right mix of DDL and VACUUM could corrupt a catalog page header such
that PageIsVerified() durably fails, requiring a restore from backup.
This affects only catalogs that both have a syscache and have DDL code
that uses syscache tuples to construct updates. One of the test
permutations shows a variant not yet fixed.
This makes !TransactionIdIsValid(TM_FailureData.xmax) possible with
TM_Deleted. I think core and PGXN are indifferent to that.
Per bug #17821 from Alexander Lakhin. Back-patch to v13 (all supported
versions). The test case is v17+, since it uses INJECTION_POINT.
Discussion: https://postgr.es/m/17821-dd8c334263399284@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d28cd3e7b21c41a710fd9c188a57dad99f28805f
Modified Files
--------------
src/backend/access/heap/heapam.c | 49 +++++-
src/backend/utils/cache/inval.c | 3 +
src/include/access/tableam.h | 3 +-
src/test/modules/injection_points/Makefile | 5 +-
.../expected/syscache-update-pruned.out | 87 ++++++++++
.../expected/syscache-update-pruned_1.out | 86 ++++++++++
.../injection_points/injection_points--1.0.sql | 8 +
src/test/modules/injection_points/meson.build | 4 +-
.../modules/injection_points/regress_injection.c | 71 ++++++++
.../specs/syscache-update-pruned.spec | 179 +++++++++++++++++++++
10 files changed, 490 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: At update of non-LP_NORMAL TID, fail instead of corrupting page
In-Reply-To: <E1tblqs-003VLn-18@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox