pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add missing CommandCounterIncrement
Date: Sun, 26 Jan 2025 16:38:19 +0000
Message-ID: <E1tc5eN-003gLV-5n@gemulon.postgresql.org> (raw)

Add missing CommandCounterIncrement

For commit b663b9436e75 I thought this was useless, but turns out not to
be for the case where a partitioned table has two identical foreign key
constraints which can both be matched by the same constraint in a
partition during attach.  This CCI makes the match search for the second
constraint in the parent ignore the constraint in the child that has
already been matched by the first constraint in the parent.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/c599253c-1ccd-4161-80fc-c9065e037a09@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0a16c8326c5a14abd180eeefe5e5ee4263513c2a

Modified Files
--------------
src/backend/commands/tablecmds.c          | 20 ++++++++++----------
src/test/regress/expected/foreign_key.out | 10 ++++++++++
src/test/regress/sql/foreign_key.sql      | 11 +++++++++++
3 files changed, 31 insertions(+), 10 deletions(-)



view thread (2+ messages)

Message-ID: <E1tc5eN-003gLV-5n@gemulon.postgresql.org>
Permalink:  ../E1tc5eN-003gLV-5n@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tc5eN-003gLV-5n@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add missing CommandCounterIncrement
  In-Reply-To: <E1tc5eN-003gLV-5n@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox