From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Print out error position for some ALTER TABLE ALTER COLUMN type
Date: Mon, 27 Jan 2025 04:52:34 +0000
Message-ID: <E1tcH6w-003mvA-44@gemulon.postgresql.org> (raw)
Print out error position for some ALTER TABLE ALTER COLUMN type
A ParseState exists in ATPrepAlterColumnType() since its introduction
in 077db40fa1f3, and it has never relied on a query string that could be
used to point at a location in the origin string on error.
The output of some regression tests are updated, showing the error
location where applicable. Six error strings are upgraded with the
error location.
Author: Jian He
Discussion: https://postgr.es/m/CACJufxGfbPfWLjcEz33G9eW_epDW0UDi2H05i9eSTPKGJ4rxSA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/65281391a937293db7fa747be218def0e9794550
Modified Files
--------------
src/backend/commands/tablecmds.c | 26 ++++++++++++++++----------
src/test/regress/expected/alter_table.out | 14 ++++++++++++++
src/test/regress/expected/generated_stored.out | 2 ++
src/test/regress/expected/typed_table.out | 2 ++
4 files changed, 34 insertions(+), 10 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Print out error position for some ALTER TABLE ALTER COLUMN type
In-Reply-To: <E1tcH6w-003mvA-44@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox