pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Revert "Speed up tail processing when hashing aligned C strings" 3+ messages / 1 participants [nested] [flat]
* pgsql: Revert "Speed up tail processing when hashing aligned C strings" @ 2024-03-31 07:20 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: John Naylor @ 2024-03-31 07:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Speed up tail processing when hashing aligned C strings" This reverts commit 07f0f6abfc7f6c55cede528d9689dedecefc734a. This has shown failures on both Valgrind and big-endian machines, per members skink and pike. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f4ad0021aface01ee74604355bd2e998e5f73320 Modified Files -------------- src/include/common/hashfn_unstable.h | 44 ++++++++---------------------------- 1 file changed, 10 insertions(+), 34 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Revert "Speed up tail processing when hashing aligned C strings, @ 2025-01-29 06:58 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: John Naylor @ 2025-01-29 06:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Speed up tail processing when hashing aligned C strings, take two" This reverts commit a365d9e2e8c1ead27203a4431211098292777d3b. Older versions of Valgrind raise an error, so go back to the bytewise loop for the final word in the input. Reported-by: Anton A. Melnikov <a.melnikov@postgrespro.ru> Discussion: https://postgr.es/m/a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/235328ee4ae49cd5abf3c1c9b81f3b809507e5f2 Modified Files -------------- src/include/common/hashfn_unstable.h | 46 ++++++++---------------------------- 1 file changed, 10 insertions(+), 36 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Revert "Speed up tail processing when hashing aligned C strings, @ 2025-01-29 06:58 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: John Naylor @ 2025-01-29 06:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Speed up tail processing when hashing aligned C strings, take two" This reverts commit a365d9e2e8c1ead27203a4431211098292777d3b. Older versions of Valgrind raise an error, so go back to the bytewise loop for the final word in the input. Reported-by: Anton A. Melnikov <a.melnikov@postgrespro.ru> Discussion: https://postgr.es/m/a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6555fe19791476b034179149e33760b07f676c87 Modified Files -------------- src/include/common/hashfn_unstable.h | 46 ++++++++---------------------------- 1 file changed, 10 insertions(+), 36 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-01-29 06:58 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-03-31 07:20 pgsql: Revert "Speed up tail processing when hashing aligned C strings" John Naylor <john.naylor@postgresql.org> 2025-01-29 06:58 pgsql: Revert "Speed up tail processing when hashing aligned C strings, John Naylor <john.naylor@postgresql.org> 2025-01-29 06:58 pgsql: Revert "Speed up tail processing when hashing aligned C strings, John Naylor <john.naylor@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox