pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Speed up tail processing when hashing aligned C strings,
Date: Wed, 29 Jan 2025 06:58:22 +0000
Message-ID: <E1td21m-004A7s-5R@gemulon.postgresql.org> (raw)

Revert "Speed up tail processing when hashing aligned C strings, take two"

This reverts commit a365d9e2e8c1ead27203a4431211098292777d3b.

Older versions of Valgrind raise an error, so go back to the bytewise
loop for the final word in the input.

Reported-by: Anton A. Melnikov <a.melnikov@postgrespro.ru>
Discussion: https://postgr.es/m/a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/235328ee4ae49cd5abf3c1c9b81f3b809507e5f2

Modified Files
--------------
src/include/common/hashfn_unstable.h | 46 ++++++++----------------------------
1 file changed, 10 insertions(+), 36 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1td21m-004A7s-5R@gemulon.postgresql.org>
Permalink:  ../E1td21m-004A7s-5R@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1td21m-004A7s-5R@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "Speed up tail processing when hashing aligned C strings,
  In-Reply-To: <E1td21m-004A7s-5R@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox