From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove obsolete restriction on the range of log_rotation_size.
Date: Fri, 31 Jan 2025 19:37:03 +0000
Message-ID: <E1tdwp5-004g1b-Nt@gemulon.postgresql.org> (raw)
Remove obsolete restriction on the range of log_rotation_size.
When syslogger.c was first written, we didn't want to assume that
all platforms have 64-bit ftello. But we've been assuming that
since v13 (cf commit 799d22461), so let's use that in syslogger.c
and allow log_rotation_size to range up to INT_MAX kilobytes.
The old code effectively limited log_rotation_size to 2GB regardless
of platform. While nobody's complained, that doesn't seem too far
away from what might be thought reasonable these days.
I noticed this while searching for instances of "1024L" in connection
with commit 041e8b95b. These were the last such instances.
(We still have instances of L-suffixed literals, but most of them
are associated with wait intervals for pg_usleep or similar functions.
I don't see any urgent reason to change that.)
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d4c3a6b8ad830882066122081a7141ecd573f45d
Modified Files
--------------
src/backend/postmaster/syslogger.c | 14 ++++++++------
src/backend/utils/misc/guc_tables.c | 2 +-
2 files changed, 9 insertions(+), 7 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove obsolete restriction on the range of log_rotation_size.
In-Reply-To: <E1tdwp5-004g1b-Nt@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox