From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Doc: add commentary about cowboy assignment of maintenance_work_
Date: Fri, 31 Jan 2025 20:17:23 +0000
Message-ID: <E1tdxS6-004gRR-Uq@gemulon.postgresql.org> (raw)
Doc: add commentary about cowboy assignment of maintenance_work_mem.
Whilst working on commit 041e8b95b I happened to notice that
parallel_vacuum_main() assigns directly to the maintenance_work_mem
GUC. This is definitely not per project conventions, so I tried to
fix it to use SetConfigOption(). But that fails with "parameter
cannot be set during a parallel operation". It doesn't seem worth
working on a cleaner answer, at least not till we have a few more
instances of similar problems. But add some commentary, just so
nobody gets the idea that this is an approved way to set a GUC.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/53a49365052026907afff7613929710d1e7f0da0
Modified Files
--------------
src/backend/commands/vacuumparallel.c | 7 +++++++
1 file changed, 7 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Doc: add commentary about cowboy assignment of maintenance_work_
In-Reply-To: <E1tdxS6-004gRR-Uq@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox