pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: injection_points: Re-enable permutation in isolation test "basic
Date: Thu, 06 Feb 2025 01:41:03 +0000
Message-ID: <E1tfqt5-005azj-Cw@gemulon.postgresql.org> (raw)

injection_points: Re-enable permutation in isolation test "basic"

This test has been disabled in 9f00edc22888 due to an instable expected
output, where it would be possible for the wait step to report its
result after the detach step is done.  The expected output was ordered
so as the detach would always report last.

Isolation test permutations have the option to use markers to control
the ordering for cases like this one, as documented in
src/test/isolation/README.  The permutation is enabled once again, this
time with a marker added so as the detach step reports only once the
wait step has finished, ensuring a correct output ordering.

Reviewed-by: Bertrand Drouvot
Discussion: https://postgr.es/m/Z6MBZTX5EqQ6A8Zc@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9e020050b8fa8e184bc1d58e6a4bc1edfa76cb8c

Modified Files
--------------
.../modules/injection_points/expected/basic.out    | 26 ++++++++++++++++++++++
src/test/modules/injection_points/specs/basic.spec | 11 +++++----
2 files changed, 31 insertions(+), 6 deletions(-)



Message-ID: <E1tfqt5-005azj-Cw@gemulon.postgresql.org>
Permalink:  ../E1tfqt5-005azj-Cw@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tfqt5-005azj-Cw@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: injection_points: Re-enable permutation in isolation test "basic
  In-Reply-To: <E1tfqt5-005azj-Cw@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox