pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: injection_points: Tweak more permutation in isolation test "basi
Date: Fri, 07 Feb 2025 04:59:29 +0000
Message-ID: <E1tgGSf-005mtE-12@gemulon.postgresql.org> (raw)

injection_points: Tweak more permutation in isolation test "basic"

The CI has reported that using a marker to force the output of the
detach step to happen after the wait step was not enough, as
isolationtester has managed to report the detach step as waiting before
the wait step finishes in some runs.

src/test/isolation/README tells that there is a more drastic method to
enforce the ordering of the output: an empty step positioned just after
the wait step can force the wait step to complete before the detach step
begins.  This method has been able to pass 10 runs in the CI here, while
HEAD seems to fail 15~20% of the time in the CF bot.

Discussion: https://postgr.es/m/Z6WO8FbqK_FHmrzC@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/926c7fce03603b49dd2529e37d47b805730584fc

Modified Files
--------------
src/test/modules/injection_points/expected/basic.out | 3 ++-
src/test/modules/injection_points/specs/basic.spec   | 7 ++++---
2 files changed, 6 insertions(+), 4 deletions(-)



Message-ID: <E1tgGSf-005mtE-12@gemulon.postgresql.org>
Permalink:  ../E1tgGSf-005mtE-12@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tgGSf-005mtE-12@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: injection_points: Tweak more permutation in isolation test "basi
  In-Reply-To: <E1tgGSf-005mtE-12@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox