pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unnecessary (char *) casts [mem]
Date: Wed, 12 Feb 2025 07:54:26 +0000
Message-ID: <E1ti7Zi-006hZf-AQ@gemulon.postgresql.org> (raw)

Remove unnecessary (char *) casts [mem]

Remove (char *) casts around memory functions such as memcmp(),
memcpy(), or memset() where the cast is useless.  Since these
functions don't take char * arguments anyway, these casts are at best
complicated casts to (void *), about which see commit 7f798aca1d5.

Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/827b4060a8e35047c1adc9ca2ab3d8e7ad905df0

Modified Files
--------------
contrib/pg_trgm/trgm_gist.c                 |  6 +++---
contrib/xml2/xpath.c                        |  4 ++--
src/backend/access/common/heaptuple.c       |  6 +++---
src/backend/access/heap/heapam_xlog.c       | 12 ++++++------
src/backend/access/table/toast_helper.c     |  2 +-
src/backend/access/transam/xlog.c           |  2 +-
src/backend/access/transam/xlogreader.c     |  2 +-
src/backend/bootstrap/bootstrap.c           |  4 ++--
src/backend/libpq/be-secure-gssapi.c        |  2 +-
src/backend/replication/logical/decode.c    |  8 ++------
src/backend/storage/buffer/bufmgr.c         |  2 +-
src/backend/storage/buffer/localbuf.c       |  2 +-
src/backend/storage/file/fd.c               |  4 ++--
src/backend/storage/page/bufpage.c          |  8 ++++----
src/backend/tcop/postgres.c                 |  4 ++--
src/backend/utils/activity/backend_status.c |  4 ++--
src/interfaces/ecpg/compatlib/informix.c    |  2 +-
src/interfaces/ecpg/ecpglib/misc.c          | 14 +++++++-------
src/interfaces/libpq/fe-lobj.c              |  2 +-
src/interfaces/libpq/fe-secure-gssapi.c     |  2 +-
20 files changed, 44 insertions(+), 48 deletions(-)



Message-ID: <E1ti7Zi-006hZf-AQ@gemulon.postgresql.org>
Permalink:  ../E1ti7Zi-006hZf-AQ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ti7Zi-006hZf-AQ@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove unnecessary (char *) casts [mem]
  In-Reply-To: <E1ti7Zi-006hZf-AQ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox