From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unnecessary (char *) casts [checksum]
Date: Wed, 12 Feb 2025 08:05:32 +0000
Message-ID: <E1ti7kS-006heV-FU@gemulon.postgresql.org> (raw)
Remove unnecessary (char *) casts [checksum]
Remove some (char *) casts related to uses of the pg_checksum_page()
function. These casts are useless, because everything involved
already has the right type. Moreover, these casts actually silently
discarded a const qualifier. The declaration of a higher-level
function needs to be adjusted to fix that.
Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1b5841d4615045e48c3a0019e36f91e4e71d0912
Modified Files
--------------
contrib/pageinspect/rawpage.c | 2 +-
src/backend/storage/page/bufpage.c | 6 +++---
src/include/storage/bufpage.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unnecessary (char *) casts [checksum]
In-Reply-To: <E1ti7kS-006heV-FU@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox