pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
4+ messages / 2 participants
[nested] [flat]
* pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
@ 2025-02-14 17:59 Melanie Plageman <melanieplageman@gmail.com>
2025-02-14 20:45 ` Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 4+ messages in thread
From: Melanie Plageman @ 2025-02-14 17:59 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Convert heap_vac_scan_next_block() boolean parameters to flags
The read stream API only allows one piece of extra per block state to be
passed back to the API user (per_buffer_data). lazy_scan_heap() needs
two pieces of per-buffer data: whether or not the block was all-visible
in the visibility map and whether or not it was eagerly scanned.
Convert these two pieces of information to flags so that they can be
populated by heap_vac_scan_next_block() and returned to
lazy_scan_heap(). A future commit will turn heap_vac_scan_next_block()
into the read stream callback for heap phase I vacuuming.
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CAAKRu_bmx33jTqATP5GKNFYwAg02a9dDtk4U_ciEjgBHZSVkOQ%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/32acad7d1d0a83a1815e15fe28b421d3471ef774
Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 47 +++++++++++++++++++++---------------
1 file changed, 27 insertions(+), 20 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
2025-02-14 17:59 pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Melanie Plageman <melanieplageman@gmail.com>
@ 2025-02-14 20:45 ` Daniel Gustafsson <daniel@yesql.se>
2025-02-14 21:41 ` Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Melanie Plageman <melanieplageman@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Gustafsson @ 2025-02-14 20:45 UTC (permalink / raw)
To: Melanie Plageman <melanieplageman@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org
> On 14 Feb 2025, at 18:59, Melanie Plageman <melanieplageman@gmail.com> wrote:
>
> Convert heap_vac_scan_next_block() boolean parameters to flags
This seems to have made skink upset with a Valgrind error:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-02-14%2020%3A30%3A29
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
2025-02-14 17:59 pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Melanie Plageman <melanieplageman@gmail.com>
2025-02-14 20:45 ` Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Daniel Gustafsson <daniel@yesql.se>
@ 2025-02-14 21:41 ` Melanie Plageman <melanieplageman@gmail.com>
2025-02-14 21:55 ` Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 4+ messages in thread
From: Melanie Plageman @ 2025-02-14 21:41 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: pgsql-committers@lists.postgresql.org
On Fri, Feb 14, 2025 at 3:45 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 14 Feb 2025, at 18:59, Melanie Plageman <melanieplageman@gmail.com> wrote:
> >
> > Convert heap_vac_scan_next_block() boolean parameters to flags
>
> This seems to have made skink upset with a Valgrind error:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-02-14%2020%3A30%3A29
Yep. Thanks. I replied to one of the other commits -- valgrind is mad
at two of them.
Thomas figured it out and should be committing a fix soon.
- Melanie
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags
2025-02-14 17:59 pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Melanie Plageman <melanieplageman@gmail.com>
2025-02-14 20:45 ` Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Daniel Gustafsson <daniel@yesql.se>
2025-02-14 21:41 ` Re: pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Melanie Plageman <melanieplageman@gmail.com>
@ 2025-02-14 21:55 ` Daniel Gustafsson <daniel@yesql.se>
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Gustafsson @ 2025-02-14 21:55 UTC (permalink / raw)
To: Melanie Plageman <melanieplageman@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org
> On 14 Feb 2025, at 22:41, Melanie Plageman <melanieplageman@gmail.com> wrote:
>
> On Fri, Feb 14, 2025 at 3:45 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 14 Feb 2025, at 18:59, Melanie Plageman <melanieplageman@gmail.com> wrote:
>>>
>>> Convert heap_vac_scan_next_block() boolean parameters to flags
>>
>> This seems to have made skink upset with a Valgrind error:
>>
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-02-14%2020%3A30%3A29
>
> Yep. Thanks. I replied to one of the other commits -- valgrind is mad
> at two of them.
Yeah, I noticed that after I had replied since I first went looking at the
wrong threads, sorry for the noise.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-02-14 21:55 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-02-14 17:59 pgsql: Convert heap_vac_scan_next_block() boolean parameters to flags Melanie Plageman <melanieplageman@gmail.com>
2025-02-14 20:45 ` Daniel Gustafsson <daniel@yesql.se>
2025-02-14 21:41 ` Melanie Plageman <melanieplageman@gmail.com>
2025-02-14 21:55 ` Daniel Gustafsson <daniel@yesql.se>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox