From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Correct relation size estimate with low fillfactor
Date: Wed, 19 Feb 2025 22:54:39 +0000
Message-ID: <E1tksxk-000D84-0c@gemulon.postgresql.org> (raw)
Correct relation size estimate with low fillfactor
Since commit 29cf61ade3, table_block_relation_estimate_size() considers
fillfactor when estimating number of rows in a relation before the first
ANALYZE. The formula however did not consider tuples may be larger than
available space determined by fillfactor, ending with density 0. This
ultimately means the relation was estimated to contain a single row.
The executor however places at least one tuple per page, even with very
low fillfactor values, so the density should be at least 1. Fixed by
clamping the density estimate using clamp_row_est().
Reported by Heikki Linnakangas. Fix by me, with regression test inspired
by example provided by Heikki.
Backpatch to 17, where the issue was introduced.
Reported-by: Heikki Linnakangas
Backpatch-through: 17
Discussion: https://postgr.es/m/2bf9d973-7789-4937-a7ca-0af9fb49c71e@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9ba7bcc894f1cafb0793a3a62658bd91db1dbecf
Modified Files
--------------
src/backend/access/table/tableam.c | 3 +++
src/test/regress/expected/stats.out | 17 +++++++++++++++++
src/test/regress/sql/stats.sql | 16 ++++++++++++++++
3 files changed, 36 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Correct relation size estimate with low fillfactor
In-Reply-To: <E1tksxk-000D84-0c@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox