From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix a WARNING for data origin discrepancies.
Date: Fri, 21 Feb 2025 09:17:33 +0000
Message-ID: <E1tlPA7-000Rf0-0B@gemulon.postgresql.org> (raw)
Fix a WARNING for data origin discrepancies.
Previously, a WARNING was issued at the time of defining a subscription
with origin=NONE only when the publisher subscribed to the same table from
other publishers, indicating potential data origination from different
origins. However, the publisher can subscribe to the partition ancestors
or partition children of the table from other publishers, which could also
result in mixed-origin data inclusion. So, give a WARNING in those cases
as well.
Reported-by: Sergey Tatarintsev <s.tatarintsev@postgrespro.ru>
Author: Hou Zhijie <houzj.fnst@fujitsu.com>
Author: Shlok Kyal <shlok.kyal.oss@gmail.com>
Reviewed-by: Vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 16, where it was introduced
Discussion: https://postgr.es/m/5eda6a9c-63cf-404d-8a49-8dcb116a29f3@postgrespro.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b4e0d0c53fabe7d19b6a081d6c2b98aa4df55295
Modified Files
--------------
doc/src/sgml/ref/create_subscription.sgml | 12 +--
src/backend/commands/subscriptioncmds.c | 15 ++--
src/test/subscription/t/030_origin.pl | 120 +++++++++++++++++++++++++++++-
3 files changed, 133 insertions(+), 14 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix a WARNING for data origin discrepancies.
In-Reply-To: <E1tlPA7-000Rf0-0B@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox