pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) @ 2025-02-21 11:38 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-02-21 11:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) Dumps from versions older than v16 do not know about NO INDENT in a XMLSERIALIZE() clause. This commit adjusts AdjustUpgrade.pm so as NO INDENT is discarded in the contents of the new dump adjusted for comparison when the old version is v15 or older. This should be enough to make the cross-version upgrade tests pass. Per report from buildfarm member crake. Oversight in 984410b92326. Reviewed-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/88b183f1-ebf9-4f51-9144-3704380ccae7@dunslane.net Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/514d47dfb69caec14b62b294f899b2e953cc2baa Modified Files -------------- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 6 ++++++ 1 file changed, 6 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) @ 2025-02-21 11:38 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-02-21 11:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) Dumps from versions older than v16 do not know about NO INDENT in a XMLSERIALIZE() clause. This commit adjusts AdjustUpgrade.pm so as NO INDENT is discarded in the contents of the new dump adjusted for comparison when the old version is v15 or older. This should be enough to make the cross-version upgrade tests pass. Per report from buildfarm member crake. Oversight in 984410b92326. Reviewed-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/88b183f1-ebf9-4f51-9144-3704380ccae7@dunslane.net Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/310907aaf01053bbc00972a01438997b146b3fdd Modified Files -------------- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 6 ++++++ 1 file changed, 6 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) @ 2025-02-21 11:38 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-02-21 11:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) Dumps from versions older than v16 do not know about NO INDENT in a XMLSERIALIZE() clause. This commit adjusts AdjustUpgrade.pm so as NO INDENT is discarded in the contents of the new dump adjusted for comparison when the old version is v15 or older. This should be enough to make the cross-version upgrade tests pass. Per report from buildfarm member crake. Oversight in 984410b92326. Reviewed-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/88b183f1-ebf9-4f51-9144-3704380ccae7@dunslane.net Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/665cafe8a4bd23b4f14194b0671d3ef09dc55864 Modified Files -------------- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 6 ++++++ 1 file changed, 6 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-02-21 11:38 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-02-21 11:38 pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) Michael Paquier <michael@paquier.xyz> 2025-02-21 11:38 pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) Michael Paquier <michael@paquier.xyz> 2025-02-21 11:38 pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox