pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT)
Date: Fri, 21 Feb 2025 11:38:16 +0000
Message-ID: <E1tlRMH-000SVG-2d@gemulon.postgresql.org> (raw)

Fix cross-version upgrades with XMLSERIALIZE(NO INDENT)

Dumps from versions older than v16 do not know about NO INDENT in a
XMLSERIALIZE() clause.  This commit adjusts AdjustUpgrade.pm so as NO
INDENT is discarded in the contents of the new dump adjusted for
comparison when the old version is v15 or older.  This should be enough
to make the cross-version upgrade tests pass.

Per report from buildfarm member crake.  Oversight in 984410b92326.

Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/88b183f1-ebf9-4f51-9144-3704380ccae7@dunslane.net
Backpatch-through: 16

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/514d47dfb69caec14b62b294f899b2e953cc2baa

Modified Files
--------------
src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 6 ++++++
1 file changed, 6 insertions(+)



view thread (3+ messages)  latest in thread

Message-ID: <E1tlRMH-000SVG-2d@gemulon.postgresql.org>
Permalink:  ../E1tlRMH-000SVG-2d@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tlRMH-000SVG-2d@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT)
  In-Reply-To: <E1tlRMH-000SVG-2d@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox