pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: Add --set-char-signedness to set the default char si
Date: Fri, 21 Feb 2025 18:24:13 +0000
Message-ID: <E1tlXh8-000VWg-1Y@gemulon.postgresql.org> (raw)

pg_upgrade: Add --set-char-signedness to set the default char signedness of new cluster.

This change adds a new option --set-char-signedness to pg_upgrade. It
enables user to set arbitrary signedness during pg_upgrade. This helps
cases where user who knew they copied the v17 source cluster from
x86 (signedness=true) to ARM (signedness=false) can pg_upgrade
properly without the prerequisite of acquiring an x86 VM.

Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/CB11ADBC-0C3F-4FE0-A678-666EE80CBB07%40amazon.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1aab6805919b84a2f2477132d96f2147ed36150e

Modified Files
--------------
doc/src/sgml/ref/pgupgrade.sgml             | 53 +++++++++++++++++++++++++++++
src/bin/pg_upgrade/check.c                  | 12 +++++++
src/bin/pg_upgrade/option.c                 | 12 +++++++
src/bin/pg_upgrade/pg_upgrade.c             | 10 ++++--
src/bin/pg_upgrade/pg_upgrade.h             |  3 ++
src/bin/pg_upgrade/t/005_char_signedness.pl | 17 +++++++++
6 files changed, 105 insertions(+), 2 deletions(-)



Message-ID: <E1tlXh8-000VWg-1Y@gemulon.postgresql.org>
Permalink:  ../E1tlXh8-000VWg-1Y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tlXh8-000VWg-1Y@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: pg_upgrade: Add --set-char-signedness to set the default char si
  In-Reply-To: <E1tlXh8-000VWg-1Y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox