pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Allow lwlocks to be disowned
Date: Sat, 22 Feb 2025 01:56:44 +0000
Message-ID: <E1tlel2-00049R-0M@gemulon.postgresql.org> (raw)

Allow lwlocks to be disowned

To implement AIO writes, the backend initiating writes needs to transfer the
lock ownership to the AIO subsystem, so the lock held during the write can be
released in another backend.

Other backends need to be able to "complete" an asynchronously started IO to
avoid deadlocks (consider e.g. one backend starting IO for a buffer and then
waiting for a heavyweight lock held by another relation followed by the
current holder of the heavyweight lock waiting for the IO to complete).

To that end, this commit adds LWLockDisown() and LWLockReleaseDisowned(). If
code uses LWLockDisown() it's the code's responsibility to ensure that the
lock is released in case of errors.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/1f6b50a7-38ef-4d87-8246-786d39f46ab9@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f8d7f29b3e81db59b95e4b5baaa6943178c89fd8

Modified Files
--------------
src/backend/storage/lmgr/lwlock.c | 75 +++++++++++++++++++++++++++++++++++----
src/include/storage/lwlock.h      |  2 ++
2 files changed, 71 insertions(+), 6 deletions(-)



Message-ID: <E1tlel2-00049R-0M@gemulon.postgresql.org>
Permalink:  ../E1tlel2-00049R-0M@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tlel2-00049R-0M@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Allow lwlocks to be disowned
  In-Reply-To: <E1tlel2-00049R-0M@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox