pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Do not use in-place updates for statistics import.
Date: Tue, 25 Feb 2025 01:12:26 +0000
Message-ID: <E1tmjUo-000XVD-1J@gemulon.postgresql.org> (raw)

Do not use in-place updates for statistics import.

The use of in-place updates was originally there to follow the
precedent of ANALYZE and to reduce the potential for bloat on
pg_class. Per discussion, it's not worth the risks.

Reported-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/cpdanvzykcb5o64rmapkx6n5gjypoce3y52hff7ocxupgpbxu4@53jmlyvukijo

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f3dae2ae5856dec9935a51e53216400566ef8d4f

Modified Files
--------------
src/backend/statistics/relation_stats.c    | 138 ++++++++++-------------------
src/test/regress/expected/stats_import.out |  53 -----------
src/test/regress/sql/stats_import.sql      |  33 -------
3 files changed, 47 insertions(+), 177 deletions(-)



Message-ID: <E1tmjUo-000XVD-1J@gemulon.postgresql.org>
Permalink:  ../E1tmjUo-000XVD-1J@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tmjUo-000XVD-1J@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Do not use in-place updates for statistics import.
  In-Reply-To: <E1tmjUo-000XVD-1J@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox