pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Doc: Fix pg_copy_logical_replication_slot description.
Date: Tue, 25 Feb 2025 04:25:09 +0000
Message-ID: <E1tmmVJ-000Ykc-1O@gemulon.postgresql.org> (raw)

Doc: Fix pg_copy_logical_replication_slot description.

This commit documents that the failover option is not copied when using
the pg_copy_logical_replication_slot function.

In passing, we modify the comments in the function clarifying the reason
for this behavior.

Reported-by: <duffieldzane@gmail.com>
Author: Hou Zhijie <houzj.fnst@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 17, where it was introduced
Discussion: https://postgr.es/m/173976850802.682632.11315364077431550250@wrigleys.postgresql.org

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7c906c5b46f8189a04e67bc550cba33dd3851b6e

Modified Files
--------------
doc/src/sgml/func.sgml              |  4 ++++
src/backend/replication/slotfuncs.c | 19 ++++++++++++-------
2 files changed, 16 insertions(+), 7 deletions(-)



view thread (2+ messages)

Message-ID: <E1tmmVJ-000Ykc-1O@gemulon.postgresql.org>
Permalink:  ../E1tmmVJ-000Ykc-1O@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tmmVJ-000Ykc-1O@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Doc: Fix pg_copy_logical_replication_slot description.
  In-Reply-To: <E1tmmVJ-000Ykc-1O@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox