pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid unnecessary relation stats query in pg_dump.
Date: Wed, 26 Feb 2025 03:52:45 +0000
Message-ID: <E1tn8TU-0007MQ-1N@gemulon.postgresql.org> (raw)

Avoid unnecessary relation stats query in pg_dump.

The few fields we need can be easily collected in getTables() and
getIndexes() and stored in RelStatsInfo.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reported-by: Andres Freund <andres@anarazel.de>
Co-authored-by: Corey Huinker <corey.huinker@gmail.com>
Co-authored-by: Jeff Davis <pgsql@j-davis.com>
Discussion: https://postgr.es/m/CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8f427187db78a549af316a69d54f5969db5f4951

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 145 +++++++++++++++++++---------------------------
src/bin/pg_dump/pg_dump.h |   5 +-
2 files changed, 64 insertions(+), 86 deletions(-)



Message-ID: <E1tn8TU-0007MQ-1N@gemulon.postgresql.org>
Permalink:  ../E1tn8TU-0007MQ-1N@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tn8TU-0007MQ-1N@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid unnecessary relation stats query in pg_dump.
  In-Reply-To: <E1tn8TU-0007MQ-1N@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox