From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove pgstat_flush_wal()
Date: Wed, 26 Feb 2025 06:37:53 +0000
Message-ID: <E1tnB3H-0008XK-2s@gemulon.postgresql.org> (raw)
Remove pgstat_flush_wal()
All the processes that generate WAL should call pgstat_report_wal() to
report all their statistics related to WAL, and this is already what
happens in the tree. Keeping pgstat_report_wal() is confusing while the
other routine is encouraged.
This routine is not required since fc415edf8ca8, where it was lastly
used in pgstat_report_stat() before an equivalent callback existed.
Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/Z71oPkJJICrRB5Ws@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d7cbeaf261da346d8c745870da1d31075ae0313c
Modified Files
--------------
src/backend/utils/activity/pgstat_wal.c | 11 +----------
src/include/utils/pgstat_internal.h | 2 --
2 files changed, 1 insertion(+), 12 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove pgstat_flush_wal()
In-Reply-To: <E1tnB3H-0008XK-2s@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox