From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid including explain.h in explain_format.h and explain_dr.h
Date: Fri, 28 Feb 2025 18:27:18 +0000
Message-ID: <E1to54w-000Ac8-1I@gemulon.postgresql.org> (raw)
Avoid including explain.h in explain_format.h and explain_dr.h
As per a suggestion from Tom Lane, we do this by declaring "struct
ExplainState" here and refer to that rather than "ExplainState".
Also per Tom, CreateExplainSerializeDestReceiver was still defined
in explain.h in addition to explain_dr.h. Remove leftover prototype.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: http://postgr.es/m/CA+TgmoYtaad3i21V0jqua-fbr+CR0ix6uBvEX8_s6BG96abd=g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/77cb08be510623421fc727f35980de5107eea735
Modified Files
--------------
src/backend/commands/explain_dr.c | 1 +
src/backend/tcop/dest.c | 2 +-
src/include/commands/explain.h | 2 --
src/include/commands/explain_dr.h | 6 +++--
src/include/commands/explain_format.h | 42 ++++++++++++++++++++---------------
5 files changed, 30 insertions(+), 23 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid including explain.h in explain_format.h and explain_dr.h
In-Reply-To: <E1to54w-000Ac8-1I@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox