public inbox for [email protected]help / color / mirror / Atom feed
pgsql: Fix code comment 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix code comment @ 2025-04-02 12:47 Peter Eisentraut <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Peter Eisentraut @ 2025-04-02 12:47 UTC (permalink / raw) To: [email protected] Fix code comment The changes made in commit d2b4b4c2259 contained incorrect comments: They said that certain forward declarations were necessary to "avoid including pathnodes.h here", but the file is itself pathnodes.h! So change the comment to just say it's a forward declaration in one case, and in the other case we don't need the declaration at all because it already appeared earlier in the file. Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/548184dd16d5f817e5d48ffe049acc2fda2fc86a Modified Files -------------- src/include/nodes/pathnodes.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix code comment @ 2025-04-02 12:47 Peter Eisentraut <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Peter Eisentraut @ 2025-04-02 12:47 UTC (permalink / raw) To: [email protected] Fix code comment The changes made in commit d2b4b4c2259 contained incorrect comments: They said that certain forward declarations were necessary to "avoid including pathnodes.h here", but the file is itself pathnodes.h! So change the comment to just say it's a forward declaration in one case, and in the other case we don't need the declaration at all because it already appeared earlier in the file. Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b19893b94bdea3b206cb544619d84cea6276f648 Modified Files -------------- src/include/nodes/pathnodes.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix code comment @ 2025-04-02 12:47 Peter Eisentraut <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Peter Eisentraut @ 2025-04-02 12:47 UTC (permalink / raw) To: [email protected] Fix code comment The changes made in commit d2b4b4c2259 contained incorrect comments: They said that certain forward declarations were necessary to "avoid including pathnodes.h here", but the file is itself pathnodes.h! So change the comment to just say it's a forward declaration in one case, and in the other case we don't need the declaration at all because it already appeared earlier in the file. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/748e98d05b752e05c0f860f35f17bb0ba83631ed Modified Files -------------- src/include/nodes/pathnodes.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-04-02 12:47 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-04-02 12:47 pgsql: Fix code comment Peter Eisentraut <[email protected]> 2025-04-02 12:47 pgsql: Fix code comment Peter Eisentraut <[email protected]> 2025-04-02 12:47 pgsql: Fix code comment Peter Eisentraut <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox