pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix memory leaks in px_crypt_shacrypt().
Date: Sun, 06 Apr 2025 15:57:30 +0000
Message-ID: <E1u1SNG-002yvY-0u@gemulon.postgresql.org> (raw)

Fix memory leaks in px_crypt_shacrypt().

Per Coverity.  I don't think these are of any actual significance
since the function ought to be invoked in a short-lived context.
Still, if it's trying to be neat it should get it right.

Also const-ify a constant and fix up typedef formatting.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ab6ef2bb8d9a00d205742932eb0b6daf62b34e0

Modified Files
--------------
contrib/pgcrypto/crypt-sha.c     | 16 ++++++++--------
src/tools/pgindent/typedefs.list |  1 +
2 files changed, 9 insertions(+), 8 deletions(-)



Message-ID: <E1u1SNG-002yvY-0u@gemulon.postgresql.org>
Permalink:  ../E1u1SNG-002yvY-0u@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1u1SNG-002yvY-0u@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix memory leaks in px_crypt_shacrypt().
  In-Reply-To: <E1u1SNG-002yvY-0u@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox