From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: Fix memory leak in check_for_unicode_update().
Date: Sun, 06 Apr 2025 20:12:17 +0000
Message-ID: <E1u1WLp-0030Ve-08@gemulon.postgresql.org> (raw)
pg_upgrade: Fix memory leak in check_for_unicode_update().
This function was initializing the "task" variable before a couple
of early returns. To fix, postpone the initialization until just
before it's needed.
Per Coverity.
Discussion: https://postgr.es/m/Z_KMsUH2-FEbiNjC%40nathan
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/de48056ec7d237e6a48dce907804ac26c87311ec
Modified Files
--------------
src/bin/pg_upgrade/check.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_upgrade: Fix memory leak in check_for_unicode_update().
In-Reply-To: <E1u1WLp-0030Ve-08@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox