pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clean up checking for pg_dumpall output directory
Date: Sun, 06 Apr 2025 21:05:17 +0000
Message-ID: <E1u1XB7-0030yJ-1z@gemulon.postgresql.org> (raw)

Clean up checking for pg_dumpall output directory

Coverity objected to the original code, and in any case this is much
cleaner, using the existing routine pg_check_dir() instead of rolling
its own test.

Per suggestion from Tom Lane.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/643a1a61985bef25904965053020057200d4ae48

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 58 +++++++++++++++-----------------------------
1 file changed, 20 insertions(+), 38 deletions(-)



Message-ID: <E1u1XB7-0030yJ-1z@gemulon.postgresql.org>
Permalink:  ../E1u1XB7-0030yJ-1z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1u1XB7-0030yJ-1z@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Clean up checking for pg_dumpall output directory
  In-Reply-To: <E1u1XB7-0030yJ-1z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox