From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: localbuf: Add Valgrind buffer access instrumentation
Date: Mon, 07 Apr 2025 19:24:42 +0000
Message-ID: <E1u1s5K-003Aky-0d@gemulon.postgresql.org> (raw)
localbuf: Add Valgrind buffer access instrumentation
This mirrors 1e0dfd166b3 (+ 46ef520b9566), for temporary table buffers. This
is mainly interesting right now because the AIO work currently triggers
spurious valgrind errors, and the fix for that is cleaner if temp buffers
behave the same as shared buffers.
This requires one change beyond the annotations themselves, namely to pin
local buffers while writing them out in FlushRelationBuffers().
Reviewed-by: Noah Misch <noah@leadboat.com>
Co-authored-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/3pd4322mogfmdd5nln3zphdwhtmq3rzdldqjwb2sfqzcgs22lf@ok2gletdaoe6
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8ab4241b9f4f73f2168bcaebc990f8b0a6b7bc81
Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 13 +++++++++++++
src/backend/storage/buffer/localbuf.c | 25 +++++++++++++++++++++++++
2 files changed, 38 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: localbuf: Add Valgrind buffer access instrumentation
In-Reply-To: <E1u1s5K-003Aky-0d@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox