From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Prevent 006_transfer_modes.pl from leaving files behind.
Date: Tue, 08 Apr 2025 15:58:28 +0000
Message-ID: <E1u2BLI-003JgB-00@gemulon.postgresql.org> (raw)
Prevent 006_transfer_modes.pl from leaving files behind.
This test was leaving files like delete_old_cluster.{sh,bat} in the
source directory for VPATH and meson builds. To fix, change the
directory to tmp_check before running the test, as was done in
commits 15b6d21553, 8af917be6b, and c462b054ba.
Oversight in commit af0d4901c1.
Reported-by: Andrew Dunstan <andrew@dunslane.net> (on Discord)
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/Z_RHkG770w3SE0yU%40nathan
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b0a4c3e88b8b527679216dca5e2e9cbd49514e99
Modified Files
--------------
src/bin/pg_upgrade/t/006_transfer_modes.pl | 5 +++++
1 file changed, 5 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent 006_transfer_modes.pl from leaving files behind.
In-Reply-To: <E1u2BLI-003JgB-00@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox