From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Further cleanup for directory creation on pg_dump/pg_dumpall
Date: Thu, 10 Apr 2025 16:17:19 +0000
Message-ID: <E1u2uad-003c5m-1p@gemulon.postgresql.org> (raw)
Further cleanup for directory creation on pg_dump/pg_dumpall
Instead of two separate (and different) implementations, refactor to use
a single common routine.
Along the way, remove use of a hardcoded file permissions constant in
favor of the common project setting for directory creation.
Author: Mahendra Singh Thalor <mahi6run@gmail.com>
Discussion: https://postgr.es/m/CAKYtNApihL8X1h7XO-zOjznc8Ca66Aevgvhc9zOTh6DBh2iaeA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4170298b6ecff7ce697b81e13d9a81e3b825798c
Modified Files
--------------
src/bin/pg_dump/dumputils.c | 36 ++++++++++++++++++++++++++++++++
src/bin/pg_dump/dumputils.h | 1 +
src/bin/pg_dump/pg_backup_directory.c | 36 ++------------------------------
src/bin/pg_dump/pg_dumpall.c | 39 +----------------------------------
4 files changed, 40 insertions(+), 72 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Further cleanup for directory creation on pg_dump/pg_dumpall
In-Reply-To: <E1u2uad-003c5m-1p@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox