pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Sync declarations and definitions of two new tablecmds.c functio
Date: Wed, 16 Apr 2025 21:59:13 +0000
Message-ID: <E1u5Amn-000OAR-17@gemulon.postgresql.org> (raw)

Sync declarations and definitions of two new tablecmds.c functions.

Buildfarm member drongo complained because the definitions of these
functions used "const Oid foo" where the forward declarations just
had "Oid foo".  (I'm a bit surprised that drongo seems to be the only
complainant.)  I chose to fix this by removing the "consts" because
(a) I'm generally not a fan of using const that way, and (b) it was
a minority usage even within these two functions, let alone compared
to the rest of our code base.

Oversight in commit eec0040c4, so no need for back-patch.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ab3d8afc7f426cb562d96a673f620fc6fa404ebd

Modified Files
--------------
src/backend/commands/tablecmds.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1u5Amn-000OAR-17@gemulon.postgresql.org>
Permalink:  ../E1u5Amn-000OAR-17@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1u5Amn-000OAR-17@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Sync declarations and definitions of two new tablecmds.c functio
  In-Reply-To: <E1u5Amn-000OAR-17@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox