pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: gen_node_support.pl: improve error message for unclosed struct.
Date: Tue, 22 Apr 2025 17:56:38 +0000
Message-ID: <E1u7HrJ-001Hf4-38@gemulon.postgresql.org> (raw)

gen_node_support.pl: improve error message for unclosed struct.

This error message was 'runaway "struct_name"', which isn't all
that clear; I think 'could not find closing brace for "struct_name"'
is better.  Also, provide the location of the struct start using the
script's usual '$file:$lineno' style.

Bug: #18901
Reported-by: Clemens Ruck <clemens.ruck@t-online.de>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/18901-424272abe01357e6@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eaf582806c0d6b19c081c5afecd9ddb7003e6f80

Modified Files
--------------
src/backend/nodes/gen_node_support.pl | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)



Message-ID: <E1u7HrJ-001Hf4-38@gemulon.postgresql.org>
Permalink:  ../E1u7HrJ-001Hf4-38@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1u7HrJ-001Hf4-38@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: gen_node_support.pl: improve error message for unclosed struct.
  In-Reply-To: <E1u7HrJ-001Hf4-38@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox