From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't use double-quotes in #include's of system headers, redux.
Date: Sun, 27 Apr 2025 17:23:25 +0000
Message-ID: <E1u95iv-00240l-0W@gemulon.postgresql.org> (raw)
Don't use double-quotes in #include's of system headers, redux.
This cleans up some loose ends left by commit e8ca9ed1d. I hadn't
looked closely enough at these places before, but now I have.
The use of double-quoted #includes for Perl headers in plperl_system.h
seems to be simply a mistake introduced in 6c944bf3c and faithfully
copied forward since then. (I had thought possibly it was required
by some weird Windows build setup, but there's no evidence of that in
our history.)
The occurrences in SectionMemoryManager.h and SectionMemoryManager.cpp
evidently stem from those files' origin as LLVM code. It's
understandable that LLVM would treat their own files as needing
double-quoted #includes; but they're still system headers to us.
I also applied the same check to *.c files, and found a few other
random incorrect usages in both directions.
Our ECPG headers and test files routinely use angle brackets to refer
to ECPG headers. I left those usages alone, since it seems reasonable
for an ECPG user to regard those headers as system headers.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/94b84a60729e15ee071739c3aec7fdd781123aab
Modified Files
--------------
src/backend/jit/llvm/SectionMemoryManager.cpp | 4 ++--
src/backend/storage/buffer/bufmgr.c | 4 ++--
src/bin/initdb/initdb.c | 2 +-
src/bin/pg_dump/compress_gzip.c | 2 +-
src/bin/pg_verifybackup/pg_verifybackup.c | 2 +-
src/include/jit/SectionMemoryManager.h | 8 ++++----
src/pl/plperl/plperl_system.h | 6 +++---
7 files changed, 14 insertions(+), 14 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't use double-quotes in #include's of system headers, redux.
In-Reply-To: <E1u95iv-00240l-0W@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox