pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: aio: Use runtime arguments with injections points in tests
Date: Sat, 10 May 2025 03:37:30 +0000
Message-ID: <E1uDb1m-00111P-0Y@gemulon.postgresql.org> (raw)

aio: Use runtime arguments with injections points in tests

This cleans up the code related to the testing infrastructure of AIO
that used injection points, switching the test code to use the new
facility for injection points added by 371f2db8b05e rather than tweaks
to pass and reset arguments to the callbacks run.

This removes all the dependencies to USE_INJECTION_POINTS in the AIO
code.  pgaio_io_call_inj(), pgaio_inj_io_get() and pgaio_inj_cur_handle
are now gone.

Reviewed-by: Greg Burd <greg@burd.me>
Discussion: https://postgr.es/m/Z_y9TtnXubvYAApS@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c259ba881c1098e75b53d5b232600b49e3301058

Modified Files
--------------
src/backend/storage/aio/aio.c           | 58 ++-------------------------------
src/backend/storage/aio/method_worker.c |  3 +-
src/include/storage/aio_internal.h      | 20 ------------
src/test/modules/test_aio/test_aio.c    |  4 +--
4 files changed, 5 insertions(+), 80 deletions(-)



Message-ID: <E1uDb1m-00111P-0Y@gemulon.postgresql.org>
Permalink:  ../E1uDb1m-00111P-0Y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uDb1m-00111P-0Y@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: aio: Use runtime arguments with injections points in tests
  In-Reply-To: <E1uDb1m-00111P-0Y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox