pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove GLOBALTABLESPACE_OID assert for locked buffers.
Date: Sat, 10 May 2025 14:38:58 +0000
Message-ID: <E1uDlLu-0015l5-0r@gemulon.postgresql.org> (raw)

Remove GLOBALTABLESPACE_OID assert for locked buffers.

Commit f4ece891fc2f3f96f0571720a1ae30db8030681b added the assertion in
an attempt to catch some defects even after VACUUM FULL or REINDEX.
However, IsCatalogTextUniqueIndexOid(tag.relNumber) always returns false
after a relfilenode change, provoking unintended assertion failures.

Reported-by: Adam Guo <adamguo@amazon.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Bug: #18912
Discussion: https://postgr.es/m/18912-a41c9bd0e0ad19b1@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4a4ee0c2c1e53401924101945ac3d517c0a8a559

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 2 --
1 file changed, 2 deletions(-)

Message-ID: <E1uDlLu-0015l5-0r@gemulon.postgresql.org>
Permalink:  ../E1uDlLu-0015l5-0r@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uDlLu-0015l5-0r@gemulon.postgresql.org

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove GLOBALTABLESPACE_OID assert for locked buffers.
  In-Reply-To: <E1uDlLu-0015l5-0r@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox