pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2025-07-01 d81dcc8d62 Use pg_ascii_tolower()/pg_ascii_toupper() where appropriate.
2025-06-11 e1458f2f1b Revert a few small patches that were intended for version 19.
* pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().
@ 2025-06-10 18:24 Jeff Davis <jdavis@postgresql.org>
2025-06-11 20:07 ` Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Davis @ 2025-06-10 18:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
copyfromparse.c: use pg_ascii_tolower() rather than tolower().
Avoid dependence on setlocale(). No behavior change.
Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c162@eisentraut.org
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4c787a24e7e220a60022e47c1776f22f72902899
Modified Files
--------------
src/backend/commands/copyfromparse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().
2025-06-10 18:24 pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <jdavis@postgresql.org>
@ 2025-06-11 20:07 ` Robert Haas <robertmhaas@gmail.com>
2025-06-11 22:15 ` Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <pgsql@j-davis.com>
0 siblings, 1 reply; 4+ messages in thread
From: Robert Haas @ 2025-06-11 20:07 UTC (permalink / raw)
To: Jeff Davis <jdavis@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Jun 10, 2025 at 2:24 PM Jeff Davis <jdavis@postgresql.org> wrote:
> copyfromparse.c: use pg_ascii_tolower() rather than tolower().
>
> Avoid dependence on setlocale(). No behavior change.
>
> Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c162@eisentraut.org
> Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
All 3 of these commits seem like things that could just as well have
been done after we branch.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().
2025-06-10 18:24 pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <jdavis@postgresql.org>
2025-06-11 20:07 ` Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Robert Haas <robertmhaas@gmail.com>
@ 2025-06-11 22:15 ` Jeff Davis <pgsql@j-davis.com>
2025-06-11 23:00 ` Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Davis @ 2025-06-11 22:15 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; Jeff Davis <jdavis@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
On Wed, 2025-06-11 at 16:07 -0400, Robert Haas wrote:
> All 3 of these commits seem like things that could just as well have
> been done after we branch.
Yeah, I called out my mistake here:
https://www.postgresql.org/message-id/60e8c6d0a6c08e67f15dbbe9e53df0119c710065.camel%40j-davis.com
Nobody seemed terribly upset about it so I left them. But for the sake
of ending any confusion I just reverted them. I will reapply them in a
few weeks after the branch.
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().
2025-06-10 18:24 pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <jdavis@postgresql.org>
2025-06-11 20:07 ` Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Robert Haas <robertmhaas@gmail.com>
2025-06-11 22:15 ` Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <pgsql@j-davis.com>
@ 2025-06-11 23:00 ` Robert Haas <robertmhaas@gmail.com>
0 siblings, 0 replies; 4+ messages in thread
From: Robert Haas @ 2025-06-11 23:00 UTC (permalink / raw)
To: Jeff Davis <pgsql@j-davis.com>; +Cc: Jeff Davis <jdavis@postgresql.org>; pgsql-committers@lists.postgresql.org
On Wed, Jun 11, 2025 at 6:15 PM Jeff Davis <pgsql@j-davis.com> wrote:
> On Wed, 2025-06-11 at 16:07 -0400, Robert Haas wrote:
> > All 3 of these commits seem like things that could just as well have
> > been done after we branch.
>
> Yeah, I called out my mistake here:
>
> https://www.postgresql.org/message-id/60e8c6d0a6c08e67f15dbbe9e53df0119c710065.camel%40j-davis.com
>
> Nobody seemed terribly upset about it so I left them. But for the sake
> of ending any confusion I just reverted them. I will reapply them in a
> few weeks after the branch.
Sounds good. I don't know if those commits mattered or not; my main
intention was to make sure you weren't planning to keep going. But
short-term revert seems to minimize risk, so +1 from me.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-06-11 23:00 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-06-10 18:24 pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <jdavis@postgresql.org>
2025-06-11 20:07 ` Robert Haas <robertmhaas@gmail.com>
2025-06-11 22:15 ` Jeff Davis <pgsql@j-davis.com>
2025-06-11 23:00 ` Robert Haas <robertmhaas@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox