pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "nbtree: Remove useless row compare arg."
Date: Wed, 11 Jun 2025 22:17:00 +0000
Message-ID: <E1uPTki-001E6y-2C@gemulon.postgresql.org> (raw)

Revert "nbtree: Remove useless row compare arg."

This reverts commit 54c6ea8c81db718508eeea50991d3c1c5dff54a5.

Further analysis has shown that the forcenonrequired row compare
behavior is in fact necessary, despite the new restrictions on
RowCompares imposed by _bt_set_startikey following commit 5f4d98d4.

Discussion: https://postgr.es/m/CAH2-Wzm3bKcz3TbHGem3_+SinEyG=VZVPbApQghp7YiZj+MM3g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dd2ce3792754e0705884aed15d1fd2ae43cc1500

Modified Files
--------------
src/backend/access/nbtree/nbtutils.c | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)

Message-ID: <E1uPTki-001E6y-2C@gemulon.postgresql.org>
Permalink:  ../E1uPTki-001E6y-2C@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uPTki-001E6y-2C@gemulon.postgresql.org

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "nbtree: Remove useless row compare arg."
  In-Reply-To: <E1uPTki-001E6y-2C@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox