From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_restore: Fix wrong descriptions of --with-{schema,data,statis
Date: Thu, 12 Jun 2025 14:26:16 +0000
Message-ID: <E1uPisi-001KPo-1d@gemulon.postgresql.org> (raw)
pg_restore: Fix wrong descriptions of --with-{schema,data,statistics} options.
Commit bde2fb797aa added the --with-schema, --with-data, and --with-statistics
options to pg_restore. These options control whether to restore schema, data,
or statistics if present in the archive. However, the help message and
documentation incorrectly described them as affecting what gets dumped.
This commit corrects those descriptions to clarify that the options control
restoration, not dumping.
Bug: #18952
Reported-by: TAKATSUKA Haruka <harukat@sraoss.co.jp>
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: TAKATSUKA Haruka <harukat@sraoss.co.jp>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/18952-be40a620f8b1e755@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/84914e964b447a63c5208ca2ec11ec3abfda0879
Modified Files
--------------
doc/src/sgml/ref/pg_restore.sgml | 9 ++++++---
src/bin/pg_dump/pg_restore.c | 6 +++---
2 files changed, 9 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_restore: Fix wrong descriptions of --with-{schema,data,statis
In-Reply-To: <E1uPisi-001KPo-1d@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox