From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add TAP tests to check replication slot advance during the check
Date: Sat, 14 Jun 2025 01:28:57 +0000
Message-ID: <E1uQFhZ-001YCD-2h@gemulon.postgresql.org> (raw)
Add TAP tests to check replication slot advance during the checkpoint
The new tests verify that logical and physical replication slots are still
valid after an immediate restart on checkpoint completion when the slot was
advanced during the checkpoint.
This commit introduces two new injection points to make these tests possible:
* checkpoint-before-old-wal-removal - triggered in the checkpointer process
just before old WAL segments cleanup;
* logical-replication-slot-advance-segment - triggered in
LogicalConfirmReceivedLocation() when restart_lsn was changed enough to
point to the next WAL segment.
Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497
Author: Vitaly Davydov <v.davydov@postgrespro.ru>
Author: Tomas Vondra <tomas@vondra.me>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/eb124c3d6deb5d0c7a588d847e3840bcc2cd0dcc
Modified Files
--------------
src/backend/access/transam/xlog.c | 4 +
src/backend/replication/logical/logical.c | 18 +++
src/test/recovery/meson.build | 2 +
src/test/recovery/t/046_checkpoint_logical_slot.pl | 139 +++++++++++++++++++++
.../recovery/t/047_checkpoint_physical_slot.pl | 133 ++++++++++++++++++++
5 files changed, 296 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add TAP tests to check replication slot advance during the check
In-Reply-To: <E1uQFhZ-001YCD-2h@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox