agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Sync typedefs.list with the buildfarm.
Date: Sun, 15 Jun 2025 17:08:39 +0000
Message-ID: <E1uQqqU-001neU-2y@gemulon.postgresql.org> (raw)
Sync typedefs.list with the buildfarm.
Our maintenance of typedefs.list has been a little haphazard
(and apparently we can't alphabetize worth a darn). Replace
the file with the authoritative list from our buildfarm, and
run pgindent using that.
I also updated the additions/exclusions lists in pgindent where
necessary to keep pgindent from messing things up significantly.
Notably, now that regex_t and some related names are macros not real
typedefs, we have to whitelist them explicitly. The exclusions list
has also drifted noticeably, presumably due to changes of system
headers on the buildfarm animals that contribute to the list.
Unlike in prior years, I've not manually added typedef names that
are missing from the buildfarm's list because they are not used to
declare any variables or fields. So there are a few places where
the typedef declaration itself is formatted worse than before,
e.g. typedef enum IoMethod. I could preserve the names that were
manually added to the list previously, but I'd really prefer to find
a less manual way of dealing with these cases. A quick grep finds
about 75 such symbols, most of which have never gotten any special
treatment.
Per discussion among pgsql-release, doing this now seems appropriate
even though we're still a week or two away from making the v18 branch.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b27644bade0348d0dafd3036c47880a349fe9332
Modified Files
--------------
src/backend/utils/adt/mcxtfuncs.c | 2 +-
src/include/access/heapam.h | 2 +-
src/include/executor/nodeAgg.h | 2 +-
src/include/storage/aio.h | 2 +-
src/include/storage/copydir.h | 2 +-
src/include/storage/sinval.h | 2 +-
src/include/tcop/backend_startup.h | 2 +-
src/include/utils/elog.h | 2 +-
src/include/utils/skipsupport.h | 2 +-
src/pl/plpython/plpy_cursorobject.c | 6 +-
src/pl/plpython/plpy_planobject.c | 6 +-
src/pl/plpython/plpy_resultobject.c | 6 +-
src/pl/plpython/plpy_subxactobject.c | 6 +-
src/test/modules/test_aio/test_aio.c | 4 +-
src/tools/pgindent/pgindent | 9 ++-
src/tools/pgindent/typedefs.list | 145 +++++++++++++++++++++--------------
16 files changed, 116 insertions(+), 84 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1uQqqU-001neU-2y@gemulon.postgresql.org>
Permalink: ../E1uQqqU-001neU-2y@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1uQqqU-001neU-2y@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Sync typedefs.list with the buildfarm.
In-Reply-To: <E1uQqqU-001neU-2y@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox