From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgxs.mk: remove unreachable rule for deleting regress.def.
Date: Fri, 20 Jun 2025 16:13:26 +0000
Message-ID: <E1uSeMn-002ZQU-2y@gemulon.postgresql.org> (raw)
pgxs.mk: remove unreachable rule for deleting regress.def.
We never create regress.def, and if we did this code would fail to
delete it, because "win" is not the correct PORTNAME for Windows.
This thinko seems to have originated in commit 7a6b562fd from 1999,
although it got moved around multiple times since then.
Author: Christoph Berg <myon@debian.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/aFVR7R7VDX7y2ruc@msg.df7cb.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2f6e240d7ac930698995ac608695cb0368f504f2
Modified Files
--------------
src/makefiles/pgxs.mk | 3 ---
1 file changed, 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pgxs.mk: remove unreachable rule for deleting regress.def.
In-Reply-To: <E1uSeMn-002ZQU-2y@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox