From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_recvlogical: Rename --two-phase and --failover options.
Date: Sun, 29 Jun 2025 15:32:57 +0000
Message-ID: <E1uVu1Z-003ti9-1v@gemulon.postgresql.org> (raw)
pg_recvlogical: Rename --two-phase and --failover options.
This commit renames the pg_recvlogical options --two-phase and
--failover to --enable-two-phase and --enable-failover, respectively.
The new names distinguish these enabling options from action options
like --start and --create-slot, while clearly indicating their purpose
to enable specific logical slot features.
The option --failover is new in PostgreSQL 18 (commit cf2655a9029), so
no compatibility break there. The option --two-phase has existed
since PostgreSQL 15 (commit cda03cfed6b), so for compatibility we keep
the old option name --two-phase around as deprecated.
Also note that pg_createsubscriber has acquired an --enable-two-phase
option, so this increases consistency across tools.
Co-authored-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/a28f66df-1354-4709-8d63-932ded4cac35@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6d12d5a433c9c8cbf92fc19afd2a3465f275564c
Modified Files
--------------
doc/src/sgml/logicaldecoding.sgml | 2 +-
doc/src/sgml/ref/pg_recvlogical.sgml | 9 +++++----
src/bin/pg_basebackup/pg_recvlogical.c | 20 +++++++++++---------
src/bin/pg_basebackup/t/030_pg_recvlogical.pl | 4 ++--
4 files changed, 19 insertions(+), 16 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_recvlogical: Rename --two-phase and --failover options.
In-Reply-To: <E1uVu1Z-003ti9-1v@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox