pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve code comment
Date: Tue, 01 Jul 2025 16:49:06 +0000
Message-ID: <E1uWeAM-004DW0-0y@gemulon.postgresql.org> (raw)

Improve code comment

The previous wording was potentially confusing about the impact of the
OVERRIDING clause on generated columns.  Reword slightly to avoid
that.

Reported-by: jian he <jian.universality@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxFMBe0nPXOQZMLTH4Ry5Gyj4m%2B2Z05mRi9KB4hk8rGt9w%40m...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fff0d1edf567c412c9d78cb10e9b67ce78b8e0cb

Modified Files
--------------
src/backend/rewrite/rewriteHandler.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

view thread (2+ messages)

Message-ID: <E1uWeAM-004DW0-0y@gemulon.postgresql.org>
Permalink:  ../E1uWeAM-004DW0-0y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1uWeAM-004DW0-0y@gemulon.postgresql.org

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve code comment
  In-Reply-To: <E1uWeAM-004DW0-0y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox