pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: psql: Fix tab-completion after GRANT/REVOKE on LARGE OBJECT and
Date: Tue, 15 Jul 2025 09:53:28 +0000
Message-ID: <E1ubcLo-006OVB-1x@gemulon.postgresql.org> (raw)

psql: Fix tab-completion after GRANT/REVOKE on LARGE OBJECT and FOREIGN SERVER.

Previously, when pressing Tab after GRANT or REVOKE ... ON LARGE OBJECT
or ON FOREIGN SERVER, TO or FROM was incorrectly suggested by psql's
tab-completion. This was not appropriate, as those clauses are not valid
at that point.

This commit fixes the issue by preventing TO and FROM from being offered
immediately after those specific GRANT/REVOKE statements.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/20250408122857.b2b06dde4e6a08290af02336@sraoss.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ff0bcb248e6ef337902cb26266606c1ab4ea4048

Modified Files
--------------
src/bin/psql/tab-complete.in.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)



Message-ID: <E1ubcLo-006OVB-1x@gemulon.postgresql.org>
Permalink:  ../E1ubcLo-006OVB-1x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ubcLo-006OVB-1x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: psql: Fix tab-completion after GRANT/REVOKE on LARGE OBJECT and
  In-Reply-To: <E1ubcLo-006OVB-1x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox