pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add assertions for all the required index AM callbacks
Date: Sun, 27 Jul 2025 08:49:36 +0000
Message-ID: <E1ufx4a-000xDE-0Z@gemulon.postgresql.org> (raw)

Add assertions for all the required index AM callbacks

Similar checks are done for the mandatory table AM callbacks.  A portion
of the index AM callbacks are optional and can be NULL; the rest is
mandatory and is documented as such in the documentation and in amapi.h.

These checks are useful to detect quickly if all the mandatory callbacks
are defined when implementing a new index access method, as the
assertions are run when loading the AM.

Author: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/ME0P300MB0445795D31CEAB92C58B41FDB651A@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6f22a82a401d267e4bf1fcbcff8d6adb24e14d58

Modified Files
--------------
src/backend/access/index/amapi.c | 13 +++++++++++++
1 file changed, 13 insertions(+)



Message-ID: <E1ufx4a-000xDE-0Z@gemulon.postgresql.org>
Permalink:  ../E1ufx4a-000xDE-0Z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ufx4a-000xDE-0Z@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add assertions for all the required index AM callbacks
  In-Reply-To: <E1ufx4a-000xDE-0Z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox